Issue #131 - Pin jsonschema to 3.2.0 #132
Conversation
adammkelly
changed the title
| @@ -1,4 +1,4 @@ | |||
| jsonschema | |||
| jsonschema==3.2.0 | |||
There was a problem hiding this comment.
Maybe remove that dependency completely as is being required already by the openapi-schema-validator dependency (and also remove from setup.cfg)?
There was a problem hiding this comment.
That's true but we use jsonschema directly also and version requirements for these two libraries can be different.
There was a problem hiding this comment.
But pinning (==) on one side of two never solves such a different needs problem with pip - there must be intervals of versions so that pip can find a non-empty intersection with versions to choose from (as only a single version can be installed inside an environment.
There was a problem hiding this comment.
I agree, this should be caret requirement ^3.2.0 before we move to 4.x
There was a problem hiding this comment.
@p1c2u caret reads a bit npmish to me, wouldn't that be jsonschema~=3.2.0 for requirements.txt if we are afraid of upstream future versions 3.3 and larger? Update: Ah, poetry accepts that ("^3.2.0") also in pyproject.toml.
There was a problem hiding this comment.
Yeah, I plan to move the library to poetry, that's why
There was a problem hiding this comment.
@sthagen this is just for requirements.txt which is used for testing environment. For setup.cfg I would set jsonschema<5.0.0to exclude future version with incompatible iter_errors.
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 98.46% 98.14% -0.33%
==========================================
Files 19 19
Lines 520 538 +18
==========================================
+ Hits 512 528 +16
- Misses 8 10 +2
Continue to review full report at Codecov.
|
No description provided.