Support '{var}' in filenames #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markrofail
changed the title
thatch
reviewed
Oct 18, 2020
thatch
reviewed
Oct 18, 2020
thatch
reviewed
Oct 18, 2020
thatch
reviewed
Oct 18, 2020
thatch
reviewed
Oct 18, 2020
|
Looking good, and thanks for the PR. Minor comments inline. |
[fix] remove redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #9
To add support for {var} in filepath I had to move some things around
1- add matching var pattern to
variablesfromtemplate_path2- move
local_pathdefinition afterinput()I also took the liberty of replacing
os.pathmethods with their equivalentpathlibmethods to avoid moving fromPathandstrformats so much.if you view the diff without whitespace changes it would be simpler
