-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image.verify raises struct.error (instead of IndexError) on Pillow > 2.7.0 #1755
Comments
Verified that this test (for IndexError) works on 2.3.0, the last version I was testing with. I'll check a few more versions to try to narrow it down. |
2.9.0: Broken |
The underlying implementation of the binary functions changed to |
That change was in PR #1121, which was released in 2.8.0. |
Given that you've created a PR in another project to act on this, are you right for this issue to be closed? |
I mean... I need to support both in any case, so I don't care. The question is more what you feel is a more appropriate error as far as I'm concerned. :-) I'm guessing struct.error might make more sense? But OTOH I personally wouldn't have known that was a struct.error if you hadn't told me, which makes the error message pretty opaque. But yeah, I personally don't need anything from you on this. |
We've treated this as an error for opening files, it makes sense to do it for verify. (though, verify is a very inconsistently supported function, currently it's only available for pngs) |
Similar to #1163 in form, but maybe not in cause.
The text was updated successfully, but these errors were encountered: