-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support saving uncompressed ICO #2512
Comments
❓ Is this a feature request? |
Duplicate of #2513? |
It's a different issue. |
@pdknsk That issue was about sub-images; this issue is not a duplicate. This is a feature-request (which I share) for non-compressed ICO files; could it be re-opened? The following is hard-coded:
And, unfortunately, this is triggering mate-desktop/eom#310 |
So from https://docs.microsoft.com/en-us/previous-versions//dd183376(v=vs.85)?redirectedfrom=MSDN, you're after "BI_RGB", "An uncompressed format", yes? Looking at https://en.wikipedia.org/wiki/ICO_(file_format), I'm guessing this would be BMP, instead of PNG. Does that sound right? |
I've concluded that the BITMAPINFOHEADER structure isn't used, so BI_RGB is irrelevant. I've created #5513 to add BMP format, through |
Currently Pillow basically writes multiple PNGs into an ICO container, which is not supported by some applications that can read ICO. I'm not familiar with the ICO format, but I think
biCompression
here references the possible sub-formats.The text was updated successfully, but these errors were encountered: