Added ICO saving in BMP format #5513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
commented
May 26, 2021
Comment on lines
+81
to
+84
| and_mask = Image.new("1", tmp.size) | ||
| ImageFile._save( | ||
| and_mask, image_io, [("raw", (0, 0) + tmp.size, 0, ("1", 0, -1))] | ||
| ) |
There was a problem hiding this comment.
Our 1, L, P and RGB modes don't have any transparency, so the AND mask can just be constant.
There was a problem hiding this comment.
Will transparency still work for BMP-formatted ICO images?
There was a problem hiding this comment.
RGBA images saved to BMP-formatted ICO will have transparency, because 32-bit images don't require the AND mask (see https://en.wikipedia.org/wiki/ICO_(file_format) for more information).
|
Looks good, let's also add to release notes. |
|
Done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2512
ICO can either be a container for PNG or BMP.
Pillow has been saving ICOs only in the PNG format. This PR adds support for saving ICOs with the BMP format, largely by reversing the process that we use to load the BMP format. It would be called with
im.save("out.ico", bitmap_format="bmp")