Pruning manifest to those items we need #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugovk I've looked at the output file manifest from this change, and I think it's actually correct. Check-manifest is freaking out, but I don't think it's actually calculating the files correctly. Can you take a look at this? |
|
I also see a discrepancy between what For example, the former complains Tests/*.py are missing, but the latter includes them. Python 2.7.10 With this branch, MANIFEST.in contains: I get this output locally: Running and Pillow.egg-info/SOURCES.txt contains: |
|
Reported: mgedmin/check-manifest#65 |
|
I could have sworn that the tests were actually included, but looking at Pillow.egg-info/SOURCES.txt, (edit -- after a clean checkout and running make sdist) they weren't there. I've pushed an update for that, and am going to rebase to catch the recently added added lines. |
|
I've force pushed the rebase, so now anything that the original issue w/ check-manifest is going to be off in the ether. |
wiredfool
force-pushed
the
manifest
branch
2 times, most recently
from
155b0f1
to
e2f7652
Compare
|
Right, and now rebased to fix merge errors from the changes I just merged to master. |
hugovk
added a commit
that referenced
this pull request
Feb 1, 2016
Pruning manifest to those items we need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pruning manifest to those items we need and in larger chunks to reduce thrashing.
However. Check-manifest barfs mightily, and complains that there are a hell of a long list of things that aren't included. If you check in the actual generated manifest,
SOURCES.txt, they are actually there, or intentionally ignored (like the source control cruft). Adding the intentional ignores back in causes warnings from the manifest generation. I'd prefer to fix or ignore check-manifest, because it's clearly wrong.