Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all compressed tiffs through libtiff #2899

Merged
merged 13 commits into from
Dec 27, 2017

Conversation

wiredfool
Copy link
Member

@wiredfool wiredfool commented Dec 20, 2017

Supercedes #2882
Fixes #2839, #2503, #1270

Changes proposed in this pull request:

  • All tiff reads of compressed tiffs run through libtiff
  • Test helper to show differences on failures
  • More end to end tiff tests

@wiredfool
Copy link
Member Author

release notes #2832

@wiredfool
Copy link
Member Author

Ok, I think this is good. I've removed the tiff_lzw decoder, as it's only used for Tiffs. The packbits decoder is still used in the PsdImagePlugin, so it remains in the tree. Jpeg is obviously used elsewhere, but support in TiffImagePlugin has been removed, as it's got colorspace issues.

@wiredfool wiredfool added this to the 4.4.0 milestone Dec 20, 2017
rawmode = 'I;16N'
if '16B' in rawmode:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;16B and ;16L here and below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's actually necessary, as there's no other use of 16B without the ;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no use other 16B, but this more explicitly tells where you are expecting to find this and which part of mode this should be.

files.
.. note::

Beginning in version 4.4.0, Pillow requires libtiff to read or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 5.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to have to do a blanket 4.4/5.0 replace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants