-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all compressed tiffs through libtiff #2899
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ca0be9c
Add value in TiffImagePlugin in compression list
bc6683c
tiff-colors-fix test adjust
bec8f41
end to end test helper, more end to end tests for tiffs
wiredfool 4877552
Read all compressed files through libtiff.
wiredfool d698d52
Added end to end tests in test_file_libtiff
wiredfool 4b4f7d6
Refactor to use features
wiredfool e617d05
These tests/features now require libtiff
wiredfool c816932
Docs for libtiff read w/compression change
wiredfool 768668c
Added RGB*;16N Unpackers
wiredfool 60e29e5
dropping tiff_lzw implementation
wiredfool cbcb51c
removing internal tiff jpeg decompression support (buggy)
wiredfool 4b3bdcd
removing internal tiff_lzw support (buggy)
wiredfool eab851c
semicolons
wiredfool File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -525,13 +525,18 @@ For more information about the SPIDER image processing package, see the | |
TIFF | ||
^^^^ | ||
|
||
PIL reads and writes TIFF files. It can read both striped and tiled images, | ||
pixel and plane interleaved multi-band images, and either uncompressed, or | ||
Packbits, LZW, or JPEG compressed images. | ||
Pillow reads and writes TIFF files. It can read both striped and tiled | ||
images, pixel and plane interleaved multi-band images. If you have | ||
libtiff and its headers installed, PIL can read and write many kinds | ||
of compressed TIFF files. If not, PIL will only read and write | ||
uncompressed files. | ||
|
||
If you have libtiff and its headers installed, PIL can read and write many more | ||
kinds of compressed TIFF files. If not, PIL will always write uncompressed | ||
files. | ||
.. note:: | ||
|
||
Beginning in version 4.4.0, Pillow requires libtiff to read or | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. version 5.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're going to have to do a blanket 4.4/5.0 replace. |
||
write compressed files. Prior to that release, Pillow had buggy | ||
support for reading Packbits, LZW and JPEG compressed TIFFs | ||
without using libtiff. | ||
|
||
The :py:meth:`~PIL.Image.Image.open` method sets the following | ||
:py:attr:`~PIL.Image.Image.info` properties: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;16B
and;16L
here and below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's actually necessary, as there's no other use of
16B
without the;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no use other
16B
, but this more explicitly tells where you are expecting to find this and which part of mode this should be.