-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Image.show(command="...") #4646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a really odd error on GHA Windows PyPy, unrelated to this change:
|
I've created #4695 as an alternative to this, exploring actually implementing |
hugovk
reviewed
Jun 20, 2020
hugovk
approved these changes
Jun 20, 2020
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
radarhere
reviewed
Jun 21, 2020
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Jun 21, 2020
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Jun 23, 2020
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Jun 23, 2020
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4643
Changes proposed in this pull request:
Image.show(command="...")
parameter and remove its documentation, because it hasn't been implemented since the PIL fork, and implementing it is non-trivial.