Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make and test with coverage #12

Merged
merged 6 commits into from
Nov 8, 2017

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 2, 2017

For #11.

Needs Pillow to be built with CFLAGS="-coverage", for example like python-pillow/Pillow#2781.

@wiredfool
Copy link
Member

  • This needs to have the various other python modules installed to do coverage.
RUN virtualenv -p /usr/bin/python2.7 --system-site-packages /vpy && \
    /vpy/bin/pip install nose cffi olefile nose-cov coverage coveralls cov-core && \
    chown -R pillow:pillow /vpy
  • python ./test-installed.py -v --with-coverage doesn't appear to write coverage for the c layer.

@hugovk
Copy link
Member Author

hugovk commented Oct 14, 2017

This branch now pip installs coverage modules.

This branch -- https://travis-ci.org/hugovk/docker-images/builds/287937280 -- is the same but has an updated Pillow submodule which includes the make install-coverage command from python-pillow/Pillow#2781.

Here's a build from that: https://travis-ci.org/hugovk/docker-images/builds/287937280

All are passing apart from three:

Comparing with a docker-images master build:

  • amazon-amd64: fails in the same way

Anyway, checking just a passing ones for now:

@wiredfool
Copy link
Member

wiredfool commented Nov 1, 2017

Looks like Amazon has stripped a bunch out of their amazon linux images, and the dependencies for xvfb haven't been updated. I've fixed that with my pr_12 https://github.com/python-pillow/docker-images/tree/pr_12 branch.

@hugovk
Copy link
Member Author

hugovk commented Nov 1, 2017

This PR needs updating for pytest too, re: python-pillow/Pillow#2815.

@wiredfool
Copy link
Member

Yes, but the things that are holding it up right now are orthogonal to the pytest issue.

@wiredfool wiredfool merged commit 124f0ba into python-pillow:master Nov 8, 2017
@wiredfool
Copy link
Member

Pushing the images now.

@hugovk hugovk deleted the test--with-coverage branch November 8, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants