This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
Added universal2 wheels #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
commented
Jan 27, 2023
radarhere
commented
Jan 27, 2023
config.sh
Outdated
| elif [[ "${PLAT:-}" == "x86_64" ]]; then | ||
| (macos_intel_native_build_setup && $@) | ||
| fi | ||
| } |
There was a problem hiding this comment.
There is debate about this in multi-build/multibuild#495
There was a problem hiding this comment.
I've pushed a commit as an alternative to this, making use of multi-build/multibuild#502
radarhere
commented
Jan 27, 2023
| if [ ! -d pillow-depends-main ]; then | ||
| curl -fsSL -o pillow-depends-main.zip https://github.com/python-pillow/pillow-depends/archive/main.zip | ||
| untar pillow-depends-main.zip | ||
| fi |
There was a problem hiding this comment.
The build is run twice for universal2, once for x86_64 and once for arm64, and pillow-depends only needs to be downloaded once.
nulano
reviewed
Jan 27, 2023
radarhere
force-pushed
the
universal2
branch
2 times, most recently
from
a27af1b
to
8b87d6e
Compare
|
Closing in light of #359 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #359 by adding universal2 wheels, apart from PyPy.
We don't build PyPy versions for arm64, so they're not going to work for universal2.