chore: use fstrings #250
Merged
chore: use fstrings #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branchvincent
force-pushed
the
fstrings
branch
from
8e52e87
to
16ae872
Compare
danieleades
suggested changes
Nov 18, 2021
There was a problem hiding this comment.
there's quite a few places where the f-strings are harder to read than the original syntax. This occurs when the 'structure' of the original message is obscured by the long, inline code.
I commented on the first few, but there's a lot more places here where i think this holds.
In those cases, I would suggest improving clarity by adding intermediate calculations of the message components, and then using the local variables.
the point of this lint is to make things easier to grok, so we need to be careful about cargo-culting in the lint, and missing the point of why we're using it in the first place
branchvincent
force-pushed
the
fstrings
branch
3 times, most recently
from
09b4d1c
to
5999359
Compare
|
thanks @danieleades, hopefully this is more readable |
neersighted
requested changes
Nov 19, 2021
branchvincent
force-pushed
the
fstrings
branch
from
5999359
to
d3660d3
Compare
neersighted
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards python-poetry/poetry#4776