How do you setup a forked repo for developement with poetry?

[tadeoos]

Hey,
@cauebs already mentioned in #203 that a contributing guide would come handy, for now I am struggling with setting up a proper developement environment. Since there is a pyproject.toml it makes sense to develop poetry using poetry, but when I run poetry install from forked repo dir I get:

Traceback (most recent call last):
  File "/usr/local/bin/poetry", line 7, in <module>
    from poetry.console import main
  File "/<truncated>/open-source/poetry/poetry/console/__init__.py", line 1, in <module>
    from .application import Application
  File "/<truncated>/open-source/poetry/poetry/console/application.py", line 6, in <module>
    from cleo import Application as BaseApplication
ModuleNotFoundError: No module named 'cleo'

As you can see it gets confused with imports: the actual poetry installed on my machine (/usr/local/bin/poetry) starts using paths from the forked repo and hence can't find the modules which of course aren't there since we want to install them with this command...

Any ideas? Contributors - how does your setup looks like?

[cauebs]

I don't know how the existing contributors handle this, but my workflow has become:

• Clone my fork
• poetry develop
• alias pt .venv/bin/poetry and use pt to test

See if that works for you :)

[tadeoos]

Unfortunately poetry develop returns the same error. Did you have virtual environemnt already created before using any poetry commands?

[tadeoos]

I managed to hack my way out of this impass by running poetry install commands not from the forked repository root but from the docs directory... This isn't very nice solution though

[cauebs]

Did you have virtual environemnt already created before using any poetry commands?

I believe I didn't. What error are you getting?

[tadeoos]

As I mentioned the error is the same - ModuleNotFoundError. It's all about python module import resolution...
@sdispater have you come across this problem?

[cauebs]

Ok, let me get this right: you cloned it, ran poetry develop and then how did you run it? Or did it fail in the poetry develop stage already?
Could you show us the exact sequence of commands you're running and the output you're getting?
I don't mean to annoy you, it's just that what I suggested has really worked well for me.

[tadeoos]

It goes like this:

$ git clone ... 
$ cd poetry
$ pyenv activate poetry-fork-3.6  # activate virtualenv
$ poetry install  # not working
Traceback (most recent call last):
  File "/usr/local/bin/poetry", line 7, in <module>
    from poetry.console import main
  File "/<truncated>/open-source/poetry/poetry/console/__init__.py", line 1, in <module>
    from .application import Application
  File "/<truncated>/open-source/poetry/poetry/console/application.py", line 6, in <module>
    from cleo import Application as BaseApplication
ModuleNotFoundError: No module named 'cleo'

$ poetry develop  # also not working
Traceback (most recent call last):
  File "/usr/local/bin/poetry", line 7, in <module>
    from poetry.console import main
  File "/<truncated>/open-source/poetry/poetry/console/__init__.py", line 1, in <module>
    from .application import Application
  File "/<truncated>/open-source/poetry/poetry/console/application.py", line 6, in <module>
    from cleo import Application as BaseApplication
ModuleNotFoundError: No module named 'cleo'

$ cd docs  # this would work with any other directory as well

$ poetry install  # now it's working cause local `poetry` is no longer in the `$PATH`
Updating dependencies
Resolving dependencies... (34.6s)


Package operations: 49 installs, 0 updates, 0 removals
....

[cauebs]

Hm... This probably has something to do with pyenv. But it shouldn't happen anyways.
@sdispater any ideas?

[tadeoos]

Without running any pyenv commands (i.e. running poetry commands without active venv) the error is the same, so I don't think it's connected.

btw I'm running on macOS High Sierra (10.13.5)

[cauebs]

How did you install poetry?

[tadeoos]

curl -sSL https://raw.githubusercontent.com/sdispater/poetry/master/get-poetry.py | python3

[JacobHayes]

This issue sounds like pypa/pipenv#2557. Essentially, when using global /usr/local/bin/poetry script from the repo folder, sys.path includes the repo's directory, which has a poetry package that overrides the global poetry package. The global and repo packages could of course have separate dependencies, causing issues.

You can see that in @tadeoos command output where /usr/local/bin/poetry ends up importing from "/<truncated>/open-source/poetry/poetry/console/__init__.py" instead of /usr/local/lib/python3.6/site-packages/poetry/console/__init__.py.

Like @tadeoos pointed out, it works from the docs folder because sys.path didn't include a folder containing a poetry package. I'm guessing @cauebs alias worked because it was using the venv local poetry entrypoint script instead of the global one, which may have a more precise import path?

A short term fix for this is to use python3 -m poetry which forces the global poetry package resolution. A better fix for this is to add a level of indirection with a src dir like using poetry/src/poetry instead of poetry/poetry.

[sdispater]

If you install Poetry globally via the recommended installer, there should not be any issues.

If you want to test the behavior of your modification to the poetry codebase by executing the poetry executable you can just do poetry run poetry

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.