more typechecking #5635
Merged
more typechecking #5635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
previously approved these changes
May 18, 2022
|
there's a bit more to do following the removal of |
dimbleby
force-pushed
the
poetry-core-typechecking
branch
from
5e99a74
to
4f827e6
Compare
dimbleby
force-pushed
the
poetry-core-typechecking
branch
from
4f827e6
to
82dd148
Compare
|
I've now made the changes in |
Secrus
approved these changes
May 18, 2022
This was referenced May 21, 2022
neersighted
approved these changes
May 23, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking off some type errors that will be exposed when poetry-core with its py.typed is published.
The additional parameter and return value on
EditableBuilder.build()go unused but are needed to match the parentBuilderclass. Maybe that suggests that the type signature on the parent is wrong? But probably it just doesn't matter.