Review of (explicit) encoding for files being created in text mode #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try#1027) This is minimal set of modifications, which fixed the problem. There are still more places, where files are open in text mode without explicit encoding, thus possibly failing on systems not using UTF-8 console encoding.
vlcinsky
changed the title
3 tasks
|
Note, that this PR includes modifications from PR #1085 |
|
Note, that my colleague @rhorenov have found, there is probably no need to port this PR into 1.0.0.x as this parts seems to be reimplemented there and is working well. |
sdispater
requested changes
May 28, 2019
sdispater
requested changes
Jun 23, 2019
|
all comments shall be resolved now (I feel a bit lost in the GitHub review procedure but hope to accept all the change requests). |
donkopotamus
added a commit
to donkopotamus/poetry
that referenced
this pull request
Jul 8, 2019
Fixes bug on Python 2.7, introduced in python-poetry#1088
sdispater
pushed a commit
that referenced
this pull request
Jul 17, 2019
Fixes bug on Python 2.7, introduced in #1088
2 tasks
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #1087
Includes changes for PR #1085