Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: handle pyproject exceptions for existing file #3076

Merged
merged 2 commits into from Oct 5, 2020
Merged

init: handle pyproject exceptions for existing file #3076

merged 2 commits into from Oct 5, 2020

Conversation

abn
Copy link
Member

@abn abn commented Oct 4, 2020

Resolves: #3073

@abn abn added the kind/bug Something isn't working as expected label Oct 4, 2020
@abn abn added this to the 1.1 milestone Oct 4, 2020
@abn abn requested a review from a team October 4, 2020 23:24
@abn abn added this to In progress in 1.1 via automation Oct 4, 2020
@abn
tests: improve init command test setup
a972444 
This change ensures that we create closer to reality scenarios when
testing init command.

Relates-to: python-poetry#3073
@abn
init: handle pyproject exceptions for existing file
5e43725 
Resolves: python-poetry#3073
1.1 automation moved this from In progress to Reviewer approved Oct 5, 2020
@finswimmer finswimmer merged commit 349e0dd into python-poetry:1.1 Oct 5, 2020
1.1 automation moved this from Reviewer approved to Done Oct 5, 2020
@abn abn mentioned this pull request Oct 5, 2020
Merged
@abn abn deleted the issue/3073 branch October 5, 2020 08:49
@abn abn mentioned this pull request Oct 5, 2020
Merged
@finswimmer finswimmer mentioned this pull request Oct 5, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
No open projects
1.1
  
Done
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abn @finswimmer