Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure vcs dependencies preserve editable flag #3264

Merged
merged 1 commit into from Oct 22, 2020
Merged

Ensure vcs dependencies preserve editable flag #3264

merged 1 commit into from Oct 22, 2020

Conversation

abn
Copy link
Member

@abn abn commented Oct 21, 2020

Resolves: #3263

@abn abn added the kind/bug Something isn't working as expected label Oct 21, 2020
@abn abn added this to the 1.1 milestone Oct 21, 2020
@abn abn requested a review from a team October 21, 2020 20:00
@abn abn added this to In progress in 1.1 via automation Oct 21, 2020
@abn abn mentioned this pull request Oct 21, 2020
Closed
3 tasks
finswimmer
finswimmer approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It somehow looks familiar to me. 🤔 Is it a regression?

1.1 automation moved this from In progress to Reviewer approved Oct 22, 2020
@finswimmer finswimmer merged commit 5af1ff7 into python-poetry:1.1 Oct 22, 2020
1.1 automation moved this from Reviewer approved to Done Oct 22, 2020
@abn
Copy link
Member Author

abn commented Oct 22, 2020

It somehow looks familiar to me. Is it a regression?

I think we had a similar issue a while back. I have added a test case to ensure we do not regress.

@abn abn deleted the issue/3263 branch October 22, 2020 08:44
This was referenced Oct 23, 2020
Merged
Merged
@ZeroAurora ZeroAurora mentioned this pull request Feb 7, 2021
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
No open projects
1.1
  
Done
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abn @finswimmer