Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more mypy optional error codes #5665

Merged
merged 4 commits into from
May 23, 2022
Merged

Enable more mypy optional error codes #5665

merged 4 commits into from
May 23, 2022

Conversation

mkniewallner
Copy link
Member

Pull Request Check List

  • Added tests for changed code. Not applicable
  • Updated documentation for changed code. Not applicable

Enable 2 new optional mypy error codes:

  • truthy-bool checks for unneeded conditions that will always be true.
  • redudant-expr checks for expressions that are redundant.

Also update the code a bit to comply with those 2 new options.

@mkniewallner mkniewallner marked this pull request as ready for review May 22, 2022 18:29
@Secrus Secrus requested a review from a team May 22, 2022 22:06
@neersighted neersighted merged commit 59a9fd3 into python-poetry:master May 23, 2022
@mkniewallner mkniewallner deleted the more-mypy-optional-error-codes branch May 23, 2022 07:51
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants