match requests pool_maxsize to num workers #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
approved these changes
Nov 3, 2022
neersighted
added
area/installer
neersighted
force-pushed
the
pool_maxsize
branch
from
ba1686d
to
65c0e6c
Compare
|
Thank you for pushing this across the finish line @neersighted ! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids trashing connections just to immediately re-create them when
num-worker> 10. This should provide a pretty solid speedup on beefy machines.I'm not attaching any tests because this would be hard to test and if it doesn't crash with an unknown keyword argument or something it means it's probably going to be doing what we expect.