Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass all pyproject.toml and poetry.lock from subdirectories #7295

Closed
wants to merge 2 commits into from

Conversation

xinbinhuang
Copy link

@xinbinhuang xinbinhuang commented Jan 4, 2023

relates: #7239 #7247

This change pass all pyproject.toml and poetry.lock from subdirectories. In a monorepo setup, pyproject.toml and poetry.lock may not exists in the root folder. Since users need to configure the --directory flag to control which folder to run the check on, I'll be easier if the hook by default supply all files so users don't need to configure bot the flag and the files field. Also, the default hardcoded files is a bit hidden and hard to find without looking at the source code.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@neersighted
Copy link
Member

Partial duplicate of #7242, should refer to #7239 as the target issue to close.

@xinbinhuang
Copy link
Author

xinbinhuang commented Jan 4, 2023

Hi @neersighted, I believe #7239 is for a different thing - poetry check doesn't respect the --directory flag. But this is about pre-commit hook misconfiguration

@neersighted
Copy link
Member

It's for the same thing, the pre-commit hook. The fact that --check doesn't respect the global option was discovered there, but is not what the issue originally tracked (as indicated by the issue title).

@xinbinhuang
Copy link
Author

xinbinhuang commented Jan 4, 2023

It's for the same thing, the pre-commit hook. The fact that --check doesn't respect the global option was discovered there, but is not what the issue originally tracked (as indicated by the issue title).

sure thing. I've updated the description to link to that issue, but I don't think this PR alone is enough to close it. Because poetry check still can't work with sub-directories.

@neersighted
Copy link
Member

That is tracked by a separate issue, #7240. The issue body and title are still the definitive indicator as to what an issue tracks.

@xinbinhuang
Copy link
Author

ah that makes sense. Can you help review this PR? are there any concerns on merging it or let me know if you have any comment you want me to address.

Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants