Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix certain hash miss matches in case of non weel installations #7594

Merged
merged 16 commits into from
Mar 7, 2023
Merged

Fix certain hash miss matches in case of non weel installations #7594

merged 16 commits into from
Mar 7, 2023

Commits on Mar 5, 2023

  1. Adjusted Chef.prepare() to allways write to a temporary directory. Ot… 

    …herwise we would overwrite an already existing cached wheel. This could then make the installation fail due to missmatched hashes.

Changed Executor._download_link() to validate package hashes via _populate_hashes_dict before building a new wheel incase we use a non wheel archive.
    @quantum-byte
    quantum-byte committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    5b16309 View commit details
    Browse the repository at this point in the history

  2. Fixed formatting and linting issues

    @quantum-byte
    quantum-byte committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    cb35709 View commit details
    Browse the repository at this point in the history

  3. First solution with broken test

    @quantum-byte
    quantum-byte committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    cead0bb View commit details
    Browse the repository at this point in the history

  4. Fix the test by also providing the non_wheel archive hash

    @quantum-byte
    quantum-byte committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    65c36b2 View commit details
    Browse the repository at this point in the history

  5. remove validate flag for now

    @quantum-byte
    quantum-byte committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    6143b4e View commit details
    Browse the repository at this point in the history

  6. Implement review suggestions to also make add the hash for cached non… 

    … wheel archives
    @quantum-byte
    quantum-byte committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    87181dc View commit details
    Browse the repository at this point in the history

  7. make mypy happy and improve some code comments

    @quantum-byte
    quantum-byte committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    bca4289 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Fix test_executor_should_write_pep610_url_references_for_non_wheel_ur… 

    …ls being stuck due to incomplete mocking
    @quantum-byte
    quantum-byte committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5bc6c03 View commit details
    Browse the repository at this point in the history

  2. make flake happy and removed some print debug statements :)

    @quantum-byte
    quantum-byte committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    e672978 View commit details
    Browse the repository at this point in the history

  3. make flake really happy

    @quantum-byte
    quantum-byte committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    9029971 View commit details
    Browse the repository at this point in the history

  4. Code review improvements

    @quantum-byte
    quantum-byte committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    62d92ba View commit details
    Browse the repository at this point in the history

  5. Further code review improvements and minor test improvements (cleanup… 

    … of generated files)
    @quantum-byte
    quantum-byte committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    ede8dbb View commit details
    Browse the repository at this point in the history

  6. Improved tests further

    @quantum-byte
    quantum-byte committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1d844c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. refactor test mocking logic 

    Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
    @quantum-byte @radoering
    quantum-byte and radoering committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    1772a6a View commit details
    Browse the repository at this point in the history

  2. Additional Review improvements

    @quantum-byte
    quantum-byte committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    41e2727 View commit details
    Browse the repository at this point in the history

  3. coding style

    @radoering
    radoering committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    1e1c331 View commit details
    Browse the repository at this point in the history