247 is alive completion

[mcepl]

This is an attempt to fix #247, but still unsuccesful.

@soupytwist , any idea, what's going on? I have tried to replace threading.Thead.isAlive (which has been deprecated and unnecessary since 2.6) with .join (which I guess will never be deprecated), but still doesn’t seem to work. Why rope doesn’t suggest it?

[mcepl]

@gwelymernans ^^^

[soupytwist]

I can't explain this, but I found a workaround for this issue which might hint at the reason. collections.Iterable and collections.Iterator are deprecated and now alias collections.abc.Iterable and collections.abc.Iterator, respectively. The former two are removed in 3.8.

I don't really know what's happening, but I found that adding these two lines to the else in type_hinting/utils.py makes the tests pass.

     else:
         mod_name, attr_name = type_name.rsplit('.', 1)
+        if mod_name == 'collections' and attr_name in ('Iterable', 'Iterator'):
+            mod_name = 'collections.abc'
         try:

I'm not suggesting that as a patch, but it might help give you some idea what's going on. If not... it's a potential ugly workaround. There is probably an underlying issue here that will affect similar cases, though, which should be fixed.

Hope it helps...

[mcepl]

OK, so #247 is truly fixed, but now we have another problem with Python 3.8. Let us split this PR into two.

The lesson is simple exception Exception: pass is ALWAYS The Wrong Thing™ to do.

[lucomsky]

I ran through all changes and think they are good. Can't say more deep comment in the lack of experience in rope project development.