Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for Apple backend: #465

Merged

Conversation

maiiku
Copy link
Contributor

@maiiku maiiku commented May 26, 2020

Proposed changes

  • add ability for users to supply aud for JWT as a list. This enables apple backednd to be used by both iOS login and web from / other sources login, because iOS provides bundle id as client and web from login requires service id to be supplied (to match against defined return urls and allowed domains)
  • if there's no first/last name in the response return None so that the User model is not updated to empty strings if user_details is used in the pipeline

Types of changes

Please check the type of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

solves #464

- add ability for users to supply aud for JWT as a list
- if there's no first/last name in the response return None so that the User model is not updated to empty strings if user_details is used in the pipeline
@omab omab merged commit 7d3daf5 into python-social-auth:master May 30, 2020
@omab
Copy link
Contributor

omab commented May 30, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants