fix download without path arguments

[GabrielSimonetto]

fix #1590

[Poolitzer]

thanks for this.

After a short discussion, we came to the conclusion that you are actually on something here. Telegram does define file_name, on which file_path is based, as optional. If you want to include this, we ask to change this though:

• Make a proper check if file_path exists
• If not, set the file_path to the string of the file_id
• implement a unitest for this case

This way, the actual filename will be unique. We dont think that this is ever going to happen, but better be safe then sorry

[GabrielSimonetto]

Ok, it will be done soon enough

[GabrielSimonetto]

So... I have a problem.

I don't have experience with tests, I've read some of them on tests/test_file.py, but I don't understand how they work. So I would need to do a test that build a FIle with the constructor using file_id, and then download and see if an error ocurs, but on this module we don't have a valid file_id to do this, so I don't know how that could be done. Can someone point me in some direction?

[Bibo-Joshi]

Hi, sorry for the late reply. In test_file.py, a fixture file is defined (Line 29). This acts just like an ordinary Telegram File. You can pass it to your new test like

def test_new_test(self, bot, file):
    file.file_id = 5                # Just an example
    assert file.file_id == 5

Within that test you can change the attributes of file as needed for your test. If you have more questions, please don't hesitate to ask :)

Also, please merge from master so we can make sure all the other tests are passing, too.

[Bibo-Joshi]

@GabrielSimonetto I took the liberty to go ahead and implement the test case ;)

[GabrielSimonetto]

Thanks @Bibo-Joshi, sorry for disappearing, I've been a bit busy this month.

[jh0ker]

LGTM 👍

[Eldinnie]

Thanks you for your contribution