Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable coverage reporting on pypy's py3.6 nightly branch #870

Merged

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jan 22, 2019

It currently doesn't work:
https://bitbucket.org/pypy/pypy/issues/2943/
and has been the cause of much confusion. Hopefully we can re-enable
it again later.

It currently doesn't work:
  https://bitbucket.org/pypy/pypy/issues/2943/
and has been the cause of much confusion. Hopefully we can re-enable
it again later.
@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #870 into master will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   99.21%   99.54%   +0.32%     
==========================================
  Files         101      101              
  Lines       12240    12200      -40     
  Branches      896      896              
==========================================
  Hits        12144    12144              
+ Misses         75       35      -40     
  Partials       21       21
Impacted Files Coverage Δ
trio/_sync.py 100% <0%> (+0.33%) ⬆️
trio/_highlevel_socket.py 100% <0%> (+0.91%) ⬆️
trio/_ssl.py 100% <0%> (+1.05%) ⬆️
trio/_core/tests/test_multierror.py 100% <0%> (+1.69%) ⬆️
trio/_core/_run.py 99.7% <0%> (+1.74%) ⬆️
trio/tests/test_ssl.py 100% <0%> (+2.53%) ⬆️

3 similar comments
@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #870 into master will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   99.21%   99.54%   +0.32%     
==========================================
  Files         101      101              
  Lines       12240    12200      -40     
  Branches      896      896              
==========================================
  Hits        12144    12144              
+ Misses         75       35      -40     
  Partials       21       21
Impacted Files Coverage Δ
trio/_sync.py 100% <0%> (+0.33%) ⬆️
trio/_highlevel_socket.py 100% <0%> (+0.91%) ⬆️
trio/_ssl.py 100% <0%> (+1.05%) ⬆️
trio/_core/tests/test_multierror.py 100% <0%> (+1.69%) ⬆️
trio/_core/_run.py 99.7% <0%> (+1.74%) ⬆️
trio/tests/test_ssl.py 100% <0%> (+2.53%) ⬆️

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #870 into master will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   99.21%   99.54%   +0.32%     
==========================================
  Files         101      101              
  Lines       12240    12200      -40     
  Branches      896      896              
==========================================
  Hits        12144    12144              
+ Misses         75       35      -40     
  Partials       21       21
Impacted Files Coverage Δ
trio/_sync.py 100% <0%> (+0.33%) ⬆️
trio/_highlevel_socket.py 100% <0%> (+0.91%) ⬆️
trio/_ssl.py 100% <0%> (+1.05%) ⬆️
trio/_core/tests/test_multierror.py 100% <0%> (+1.69%) ⬆️
trio/_core/_run.py 99.7% <0%> (+1.74%) ⬆️
trio/tests/test_ssl.py 100% <0%> (+2.53%) ⬆️

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #870 into master will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   99.21%   99.54%   +0.32%     
==========================================
  Files         101      101              
  Lines       12240    12200      -40     
  Branches      896      896              
==========================================
  Hits        12144    12144              
+ Misses         75       35      -40     
  Partials       21       21
Impacted Files Coverage Δ
trio/_sync.py 100% <0%> (+0.33%) ⬆️
trio/_highlevel_socket.py 100% <0%> (+0.91%) ⬆️
trio/_ssl.py 100% <0%> (+1.05%) ⬆️
trio/_core/tests/test_multierror.py 100% <0%> (+1.69%) ⬆️
trio/_core/_run.py 99.7% <0%> (+1.74%) ⬆️
trio/tests/test_ssl.py 100% <0%> (+2.53%) ⬆️

@oremanj
Copy link
Member

oremanj commented Jan 23, 2019

Thanks for tracking this down!

Relatedly, it looks like coverage might be fixed for 3.8-dev? nedbat/coveragepy#707 is resolved, at least.

@oremanj oremanj merged commit e26b908 into python-trio:master Jan 23, 2019
@njsmith njsmith deleted the disable-coverage-on-pypy-py36-nightly branch January 23, 2019 03:56
@njsmith
Copy link
Member Author

njsmith commented Jan 23, 2019

Relatedly, it looks like coverage might be fixed for 3.8-dev?

I dunno, want to try re-enabling it and seeing what happens?

@pquentin
Copy link
Member

@oremanj I already tried, see #784. I was planning to wait until the 3.8 release, but there are other options too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants