Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.7+ #76

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Support Python 3.7+ #76

merged 3 commits into from
Jul 18, 2022

Conversation

pquentin
Copy link
Member

No description provided.

sethmlarson
sethmlarson approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love seeing a switch to GHA 🥳 Did you try running flynt to upgrade formatting strings too?

@pquentin pquentin force-pushed the python37-plus branch 11 times, most recently from fb5365e to c263619 Compare July 18, 2022 14:05
@pquentin
Write bytes explicitly
f55abeb 
This avoids considerations around universal newlines that were breaking
on Windows.
@pquentin
Copy link
Member Author

Thanks! I ran flyint and pyupgrade and fixed an issue with new lines on Windows by writing bytes explicitly. Here is a successful run: https://github.com/pquentin/unasync/runs/7391237203

@pquentin pquentin merged commit 0d21b04 into python-trio:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @sethmlarson