Skip to content

Handle ConnectionClosed exception in keepalive_ping. #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2019
Merged

Handle ConnectionClosed exception in keepalive_ping. #627

merged 2 commits into from
Jun 22, 2019

Conversation

aaugustin
Copy link
Member

Fix #551.

Thanks @Harmon758 for diagnosing the root cause and proposing a fix.

@aaugustin
Handle ConnectionClosed exception in keepalive_ping.
361bcbe 
Fix #551.

Thanks @Harmon758 for reporting this bug and identifying the root cause.
@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #627   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines        2473   2487   +14     
  Branches       79     79           
=====================================
+ Hits         2473   2487   +14
Impacted Files Coverage Δ
tests/test_protocol.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c31b8...df19794. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 22, 2019 •
edited
Loading

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #627   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     12    -1     
  Lines        2473   2487   +14     
  Branches       79     79           
=====================================
+ Hits         2473   2487   +14
Impacted Files Coverage Δ
tests/test_protocol.py 100% <100%> (ø) ⬆️
tests/utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c31b8...acd623a. Read the comment docs.

@aaugustin aaugustin mentioned this pull request Jun 22, 2019
Closed
@aaugustin
Handle aborted pings when receiving a pong.
acd623a 
Fix #551.

Thanks @Harmon758 for reporting this bug and identifying the root cause.
@aaugustin aaugustin merged commit f8d8a61 into master Jun 22, 2019
@aaugustin aaugustin deleted the issue-551 branch June 22, 2019 16:25
@FinnStutzenstein FinnStutzenstein mentioned this pull request Aug 27, 2019
Closed
@aaugustin aaugustin mentioned this pull request Jul 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected ConnectionClosed in keepalive ping task
1 participant
@aaugustin