Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.8 support #607

Closed
romainr opened this issue May 1, 2020 · 3 comments
Closed

Python 3.8 support #607

romainr opened this issue May 1, 2020 · 3 comments

Comments

@romainr
Copy link

romainr commented May 1, 2020

I could not find an issue about it.

async is a reserved keyword now and will conflict, e.g. https://docs.python.org/3/reference/compound_stmts.html#async-def

python3.8/site-packages/kazoo/recipe/partitioner.py", line 185
    self._child_watching(self._allocate_transition, async=True)
                                                    ^
SyntaxError: invalid syntax
@romainr
Copy link
Author

romainr commented May 1, 2020

For the record, I was on kazoo 2.0 and 2.7 compiles without reserved keywords.

I did not test the functionalities at run time yet.

This was referenced May 9, 2020
Merged
Merged
arrdem added a commit to arrdem/kazoo that referenced this issue May 17, 2020
@arrdem
fix(core): '"is" with a literal' syntax errors
94cec07 
As of Python 3.8, "is" with a literal is a syntax warning because of the
confusion between equality and instance identity it represents.

Issue python-zk#607
arrdem added a commit to arrdem/kazoo that referenced this issue May 17, 2020
@arrdem
fix(core): '"is" with a literal' syntax errors
d4e9336 
As of Python 3.8, "is" with a literal is a syntax warning because of the
confusion between equality and instance identity it represents.

Issue python-zk#607
StephenSorriaux pushed a commit that referenced this issue May 18, 2020
@arrdem
fix(core): '"is" with a literal' syntax errors (#609)
6b6ffe6 
As of Python 3.8, "is" with a literal is a syntax warning because of the
confusion between equality and instance identity it represents.

Issue #607
@StephenSorriaux
Copy link
Member

Hello,

Kazoo officially supports Python 3.8. The current Kazoo version (2.7.0) would display a warning that was fixed in #609 and it will be integrated in the next Kazoo release.

@romainr
Copy link
Author

romainr commented May 20, 2020

Great to know!

Adding 3.8 to https://pypi.org/project/kazoo/ would document it well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romainr @StephenSorriaux