Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): remove codecov step from tox since performed in GA #719

Merged
merged 1 commit into from
Apr 10, 2023
Merged

feat(ci): remove codecov step from tox since performed in GA #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
- name: Test with tox
run: tox -e ${TOX_VENV}
env:
TOX_VENV: ${{ format('{0}-{1}', matrix.tox-env, 'gevent-eventlet-sasl,codecov') }}
TOX_VENV: ${{ format('{0}-{1}', matrix.tox-env, 'gevent-eventlet-sasl') }}
ZOOKEEPER_VERSION: ${{ matrix.zk-version }}
# TODO: can be removed once tests for ZK 3.4 are removed
ZOOKEEPER_PREFIX: "${{ !contains(matrix.zk-version, '3.4') && 'apache-' || '' }}"
Expand Down
4 changes: 0 additions & 4 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ extras =
sasl: sasl
deps =
sasl: kerberos
codecov: codecov
allowlist_externals =
{toxinidir}/ensure-zookeeper-env.sh
{toxinidir}/init_krb5.sh
Expand All @@ -40,9 +39,6 @@ commands =

[testenv:build]

[testenv:codecov]
commands = - codecov -e TOX_VENV,ZOOKEEPER_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like previously we ran coverage separately for each matrix entry... so removing this we'll only run it once, which means we lose visibility if a particular python/ zookeper version combo loses coverage unexpectedly due to a special casing in the code...

I personally think that's fine, coverage is more a "nice-to-have" tool to surface things, and rather have it run quickly than exhaustively, but wanted to document this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point. I am not sure if that coverage for each matrix entry has ever worked, or if I broke something when switching to GA. Looking at the codecov history (https://app.codecov.io/gh/python-zk/kazoo/pulls?order=ASC) does not really help, but I don't remember seeing 20+ comments from codecov in PRs from old Travis times...
Anyway, I agree with you, 1 time per PR seems good enough.


[testenv:pep8]
basepython = python3
extras = alldeps
Expand Down