Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bedevere for the GitHub migration #418

Closed
Tracked by #13
ezio-melotti opened this issue Mar 24, 2022 · 5 comments · Fixed by #420
Closed
Tracked by #13

Update bedevere for the GitHub migration #418

ezio-melotti opened this issue Mar 24, 2022 · 5 comments · Fixed by #420

Comments

@ezio-melotti
Copy link
Member

Currently bedevere does the following things:

  • checks if a bpo link is present in the PR
    • this check is no longer necessary for bpo
    • it might need to be updated to check for a GH or bpo issue
    • eventually the bpo check could be removed
  • adds a link to PRs that points to the corresponding bpo issues
    • the link should be updated to use the bpo-* form to enable redirects
      • is it possible to update existing links?
    • it might need to add links to the GH issues
    • eventually the bpo link addition can be removed
  • adds labels automatically

cc @brettcannon

@Mariatta
Copy link
Member

I've just opened the PR for handling the new labels: #419
I noticed the bpo- check while working on it. I'll try to work on a PR.

@Mariatta
Copy link
Member

Mariatta commented Mar 24, 2022

adds a link to PRs that points to the corresponding bpo issues

I'm planning to just remove this functionality completely, so that bedevere will no longer be appending issue link at the end. Is this ok?

@brettcannon
Copy link
Member

adds a link to PRs that points to the corresponding bpo issues

I'm planning to just remove this functionality completely, so that bedevere will no longer be appending issue link at the end. Is this ok?

I think so.

@ezio-melotti
Copy link
Member Author

ezio-melotti commented Mar 24, 2022

The reason to change from the full link to bpo-* (or better just add bpo-* next to it) is that bpo-* can automatically redirect to the right GH issue without having to go through the bpo issue manually. That's also why I was asking if it's possible to update old links -- if not, people will have to deal with a click more and some extra loading time, but it's not the end of the world.

It might be useful to wait a few days to disable the feature, to leave some time for people to adjust to the new workflow (some might still use the bpo ID if they are not sure what todo). After that the feature can be removed, unless you want to check that the PR is linked to an existing GH issue instead.

Mariatta added a commit that referenced this issue Mar 25, 2022
Expect gh- issue number in titles.
Remove logic for adding bpo url in the body.
Validate that the GH- issue is indeed an issue, not PR

Closes #418
Mariatta added a commit that referenced this issue Mar 25, 2022
Expect gh- issue number in titles.
Remove logic for adding bpo url in the body.
Validate that the GH- issue is indeed an issue, not PR

Closes #418
@Mariatta
Copy link
Member

Oh I have started removing the bpo- thing altogether before I saw your comment. (see #420)

Updating old prs that has bpo- in it can perhaps be done using one-off script.

@ambv ambv closed this as completed in #420 Apr 10, 2022
ambv pushed a commit that referenced this issue Apr 10, 2022
Expect gh- issue number in titles.
Remove logic for adding bpo url in the body.
Validate that the GH- issue is indeed an issue, not PR

Closes #418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants