bpo-38532: Add missing decrefs in PyCFuncPtr_FromDll() (GH-17811)

miss-islington · ZackerySpytz · Yhg1s · commit aa3efea9c5f4 · 2020-01-03T13:50:11.000+01:00
(cherry picked from commit e02ab59) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
@@ -3554,10 +3554,12 @@ PyCFuncPtr_FromDll(PyTypeObject *type, PyObject *args, PyObject *kwds)
     if (PySys_Audit("ctypes.dlsym",
                     ((uintptr_t)name & ~0xFFFF) ? "Os" : "On",
                     dll, name) < 0) {
+        Py_DECREF(ftuple);
         return NULL;
     }
 #else
     if (PySys_Audit("ctypes.dlsym", "Os", dll, name) < 0) {
+        Py_DECREF(ftuple);
         return NULL;
     }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -3554,10 +3554,12 @@ PyCFuncPtr_FromDll(PyTypeObject type, PyObject args, PyObject *kwds)`
`3554`	`3554`	`if (PySys_Audit("ctypes.dlsym",`
`3555`	`3555`	`((uintptr_t)name & ~0xFFFF) ? "Os" : "On",`
`3556`	`3556`	`dll, name) < 0) {`
	`3557`	`+ Py_DECREF(ftuple);`
`3557`	`3558`	`return NULL;`
`3558`	`3559`	`}`
`3559`	`3560`	`#else`
`3560`	`3561`	`if (PySys_Audit("ctypes.dlsym", "Os", dll, name) < 0) {`
	`3562`	`+ Py_DECREF(ftuple);`
`3561`	`3563`	`return NULL;`
`3562`	`3564`	`}`
`3563`	`3565`	`#endif`