Skip to content

Commit db53ca3

Browse files
HoKim98AA-Turner
andauthored
gh-138489: Add missing build-details.json step for building wasm (#139302)
* fix: add missing `build-details.json` step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * gh-138489: Add missing build-details.json step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * Update Makefile.pre.in Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> --------- Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
1 parent c33dc15 commit db53ca3

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

Makefile.pre.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ build_all: check-clean-src check-app-store-compliance $(BUILDPYTHON) platform sh
801801

802802
.PHONY: build_wasm
803803
build_wasm: check-clean-src $(BUILDPYTHON) platform sharedmods \
804-
python-config checksharedmods
804+
python-config checksharedmods build-details.json
805805

806806
.PHONY: build_emscripten
807807
build_emscripten: build_wasm web_example web_example_pyrepl_jspi
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
When cross-compiling for WASI by ``build_wasm`` or ``build_emscripten``, the
2+
``build-details.json`` step is now included in the build process, just like
3+
with native builds.
4+
5+
This fixes the ``libinstall`` task which requires the ``build-details.json``
6+
file during the process.

0 commit comments

Comments
 (0)