Skip to content

gh-100940: Change "char *str" to "const char *str" in KeywordToken: It is an immutable string. #100936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

gh-100940: Change "char *str" to "const char *str" in KeywordToken: It is an immutable string. #100936

merged 1 commit into from
Jan 18, 2023

Conversation

StepfenShawn
Copy link
Contributor

@StepfenShawn StepfenShawn commented Jan 11, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Jan 11, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@StepfenShawn StepfenShawn mentioned this pull request Jan 11, 2023
Closed
@StepfenShawn StepfenShawn changed the title Change "char *str" to "const char *str" in KeywordToken: It is an immutable string. gh-100940: Change "char *str" to "const char *str" in KeywordToken: It is an immutable string. Jan 11, 2023
@StepfenShawn
Copy link
Contributor Author

Could someone please review this? thanks!

@pablogsal pablogsal merged commit a1e051a into python:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StepfenShawn @bedevere-bot @lysnikolaou @sobolevn @pablogsal