Skip to content

Conversation

itsankitkp
Copy link
Contributor

@itsankitkp itsankitkp commented Apr 23, 2023

Changes made are limited to sysconfig and sites module.
Only made hard-coded values configurable, not added anything or removed

@itsankitkp itsankitkp requested a review from FFY00 as a code owner April 23, 2023 11:05
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Apr 23, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a future step, the value could maybe be based on sys.implementation.

itsankitkp and others added 2 commits December 29, 2023 17:34
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 enabled auto-merge (squash) December 29, 2023 17:36
@FFY00 FFY00 merged commit f46987b into python:main Dec 29, 2023
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

if sys.platform == 'darwin' and sys._framework:
return f'{userbase}/lib/python/site-packages'
return f'{userbase}/lib/{implementation_lower}/site-packages'

return f'{userbase}/lib/python{version[0]}.{version[1]}/site-packages'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this value? Is this intended to be kept or missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants