Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Tier 1 and 2 interpreters into a single function #111520

Closed
gvanrossum opened this issue Oct 30, 2023 · 1 comment
Closed

Merge Tier 1 and 2 interpreters into a single function #111520

gvanrossum opened this issue Oct 30, 2023 · 1 comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Oct 30, 2023 •
edited by bedevere-app bot
Loading

Currently the Tier 2 interpreter lives in a separate function. This looks clean but makes switching between tiers complicated. See faster-cpython/ideas#631. So let's make _PyEval_EvalFrameDefault() into a single function that contains both interpreter loops.

Linked PRs
@Eclips4 Eclips4 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Oct 30, 2023
@bedevere-app bedevere-app bot mentioned this issue Oct 30, 2023
Merged
gvanrossum added a commit that referenced this issue Nov 1, 2023
@gvanrossum
gh-111520: Integrate the Tier 2 interpreter in the Tier 1 interpreter (…
7e135a4 
…#111428)

- There is no longer a separate Python/executor.c file.
- Conventions in Python/bytecodes.c are slightly different -- don't use `goto error`,
  you must use `GOTO_ERROR(error)` (same for others like `unused_local_error`).
- The `TIER_ONE` and `TIER_TWO` symbols are only valid in the generated (.c.h) files.
- In Lib/test/support/__init__.py, `Py_C_RECURSION_LIMIT` is imported from `_testcapi`.
- On Windows, in debug mode, stack allocation grows from 8MiB to 12MiB.
- **Beware!** This changes the env vars to enable uops and their debugging
  to `PYTHON_UOPS` and `PYTHON_LLTRACE`.
FullteaR pushed a commit to FullteaR/cpython that referenced this issue Nov 3, 2023
@gvanrossum @FullteaR
pythongh-111520: Integrate the Tier 2 interpreter in the Tier 1 inter…
43fc9d4 
…preter (python#111428)

- There is no longer a separate Python/executor.c file.
- Conventions in Python/bytecodes.c are slightly different -- don't use `goto error`,
  you must use `GOTO_ERROR(error)` (same for others like `unused_local_error`).
- The `TIER_ONE` and `TIER_TWO` symbols are only valid in the generated (.c.h) files.
- In Lib/test/support/__init__.py, `Py_C_RECURSION_LIMIT` is imported from `_testcapi`.
- On Windows, in debug mode, stack allocation grows from 8MiB to 12MiB.
- **Beware!** This changes the env vars to enable uops and their debugging
  to `PYTHON_UOPS` and `PYTHON_LLTRACE`.
@bedevere-app bedevere-app bot mentioned this issue Nov 7, 2023
Merged
brandtbucher added a commit that referenced this issue Nov 14, 2023
@brandtbucher
GH-111520: Add back the operand local (GH-111813)
31ad7e0
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@gvanrossum @aisk
pythongh-111520: Integrate the Tier 2 interpreter in the Tier 1 inter…
724f139 
…preter (python#111428)

- There is no longer a separate Python/executor.c file.
- Conventions in Python/bytecodes.c are slightly different -- don't use `goto error`,
  you must use `GOTO_ERROR(error)` (same for others like `unused_local_error`).
- The `TIER_ONE` and `TIER_TWO` symbols are only valid in the generated (.c.h) files.
- In Lib/test/support/__init__.py, `Py_C_RECURSION_LIMIT` is imported from `_testcapi`.
- On Windows, in debug mode, stack allocation grows from 8MiB to 12MiB.
- **Beware!** This changes the env vars to enable uops and their debugging
  to `PYTHON_UOPS` and `PYTHON_LLTRACE`.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@brandtbucher @aisk
pythonGH-111520: Add back the operand local (pythonGH-111813)
6e84a04
@gvanrossum
Copy link
Member Author

FWIW, we're considering to roll this back. See gh-116970.

@gvanrossum gvanrossum mentioned this issue Mar 18, 2024
Open
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@gvanrossum @Glyphack
pythongh-111520: Integrate the Tier 2 interpreter in the Tier 1 inter…
bbf5063 
…preter (python#111428)

- There is no longer a separate Python/executor.c file.
- Conventions in Python/bytecodes.c are slightly different -- don't use `goto error`,
  you must use `GOTO_ERROR(error)` (same for others like `unused_local_error`).
- The `TIER_ONE` and `TIER_TWO` symbols are only valid in the generated (.c.h) files.
- In Lib/test/support/__init__.py, `Py_C_RECURSION_LIMIT` is imported from `_testcapi`.
- On Windows, in debug mode, stack allocation grows from 8MiB to 12MiB.
- **Beware!** This changes the env vars to enable uops and their debugging
  to `PYTHON_UOPS` and `PYTHON_LLTRACE`.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@brandtbucher @Glyphack
pythonGH-111520: Add back the operand local (pythonGH-111813)
2567f3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvanrossum @Eclips4