Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark some tests test_cmd_line as cpython_only #116858

Closed
sobolevn opened this issue Mar 15, 2024 · 1 comment
Closed

Mark some tests test_cmd_line as cpython_only #116858

sobolevn opened this issue Mar 15, 2024 · 1 comment
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Mar 15, 2024 •
edited by bedevere-app bot
Loading

Bug report

There are different tests that are skipped due to various reasons (like exact --help output matches or malloc usages, frozen imports, etc) on other implementations. For example, RustPython: https://github.com/RustPython/RustPython/blob/92c8b371ae5db0d95bd8199bc42b08af115bb88a/Lib/test/test_cmd_line.py

Take note that some skips look more like bugs / incomplete features in RustPython, however it is better to mark some tests that we can be sure as CPython-only.

I have a PR ready with the full description of each case.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Mar 15, 2024
@sobolevn sobolevn self-assigned this Mar 15, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 15, 2024
@sobolevn
pythongh-116858: Add @cpython_only to several tests in test_cmd_line
f294c57
@bedevere-app bedevere-app bot mentioned this issue Mar 15, 2024
Merged
@Eclips4
Copy link
Member

Eclips4 commented Mar 15, 2024

FYI, there's already a similiar meta issue: #115142

sobolevn added a commit that referenced this issue Mar 16, 2024
@sobolevn
gh-116858: Add @cpython_only to several tests in test_cmd_line (#…
a1c4923 
…116859)
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 16, 2024
@sobolevn
[3.12] pythongh-116858: Add @cpython_only to several tests in `test…
2eceb3e 
…_cmd_line` (pythonGH-116859)
@bedevere-app bedevere-app bot mentioned this issue Mar 16, 2024
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 16, 2024
@sobolevn
[3.11] pythongh-116858: Add @cpython_only to several tests in `test…
5dc5561 
…_cmd_line` (pythonGH-116859)
@bedevere-app bedevere-app bot mentioned this issue Mar 16, 2024
Merged
sobolevn added a commit that referenced this issue Mar 16, 2024
@sobolevn
[3.11] gh-116858: Add @cpython_only to several tests in `test_cmd_l…
d16519a 
…ine` (GH-116859) (#116890)
sobolevn added a commit that referenced this issue Mar 16, 2024
@sobolevn
[3.12] gh-116858: Add @cpython_only to several tests in `test_cmd_l…
32c7751 
…ine` (GH-116859) (#116889)
vstinner pushed a commit to vstinner/cpython that referenced this issue Mar 20, 2024
@sobolevn @vstinner
pythongh-116858: Add @cpython_only to several tests in `test_cmd_li…
4caf512 
…ne` (python#116859)
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@sobolevn @adorilson
pythongh-116858: Add @cpython_only to several tests in `test_cmd_li…
636bc27 
…ne` (python#116859)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@sobolevn @diegorusso
pythongh-116858: Add @cpython_only to several tests in `test_cmd_li…
c5bb466 
…ne` (python#116859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @Eclips4