gh-77102: site: try utf-8 and fallback to locale encoding when reading pth file #117802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
methane
commented
Apr 12, 2024
•
methane
commented
- Issue: .pth files cannot contain folders with utf-8 names #77102
vstinner
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
LGTM.
Maybe document the change https://docs.python.org/dev/whatsnew/3.13.html#improved-modules for more visibility.
|
GH-117917 is a backport of this pull request to the 3.12 branch. |
methane
added a commit
to methane/cpython
that referenced
this pull request
Apr 16, 2024
…g when reading .pth file (pythonGH-117802) (cherry picked from commit 6dc661b) Co-authored-by: Inada Naoki <songofacandy@gmail.com>
|
GH-117918 is a backport of this pull request to the 3.11 branch. |
|
GH-117917 is a backport of this pull request to the 3.12 branch. |
|
GH-117918 is a backport of this pull request to the 3.11 branch. |
methane
added a commit
that referenced
this pull request
Apr 16, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…reading .pth file (python#117802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.