Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] mangled names are incorrectly introspected by test_pyclbr.py #120449

Closed
picnixz opened this issue Jun 13, 2024 · 3 comments
Closed

[tests] mangled names are incorrectly introspected by test_pyclbr.py #120449

picnixz opened this issue Jun 13, 2024 · 3 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@picnixz
Copy link
Contributor

picnixz commented Jun 13, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

This is something I encountered when implementing #120422. It should not affect the pyclbr.py module itself since introspection is achieved without any loading (so the names are correctly picked).

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@picnixz picnixz added the type-bug An unexpected behavior, bug, or error label Jun 13, 2024
@bedevere-app bedevere-app bot mentioned this issue Jun 13, 2024
Merged
@erlend-aasland erlend-aasland added the tests Tests in the Lib/test dir label Jun 13, 2024
encukou pushed a commit that referenced this issue Jun 18, 2024
@picnixz
gh-120449: fix test_pyclbr introspection for mangled names (GH-12…
d8cd0fa 
…0450)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 18, 2024
@picnixz @miss-islington
pythongh-120449: fix test_pyclbr introspection for mangled names (p…
9ceab52 
…ythonGH-120450)

(cherry picked from commit d8cd0fa)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Jun 18, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 18, 2024
@picnixz @miss-islington
pythongh-120449: fix test_pyclbr introspection for mangled names (p…
de932b7 
…ythonGH-120450)

(cherry picked from commit d8cd0fa)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Jun 18, 2024
Merged
encukou pushed a commit that referenced this issue Jun 19, 2024
@miss-islington @picnixz
[3.13] gh-120449: fix test_pyclbr introspection for mangled names (…
d65e145 
…GH-120450) (GH-120700)

gh-120449: fix ``test_pyclbr`` introspection for mangled names (GH-120450)
(cherry picked from commit d8cd0fa)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
encukou pushed a commit that referenced this issue Jun 19, 2024
@miss-islington @picnixz
[3.12] gh-120449: fix test_pyclbr introspection for mangled names (…
57f955f 
…GH-120450) (GH-120701)

gh-120449: fix ``test_pyclbr`` introspection for mangled names (GH-120450)
(cherry picked from commit d8cd0fa)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit to picnixz/cpython that referenced this issue Jun 19, 2024
@picnixz
pythongh-120449: fix test_pyclbr introspection for mangled names (p…
033ba8a 
…ythonGH-120450)
@nineteendo
Copy link
Contributor

Could you close this?

@picnixz picnixz closed this as completed Jun 19, 2024
@picnixz
Copy link
Contributor Author

picnixz commented Jun 19, 2024

(I was waiting for the backports to be merged but I missed the notification)

@nineteendo
Copy link
Contributor

It's fine, you can occasionally go through your issues here: https://github.com/python/cpython/issues/created_by/picnixz
Or your pull requests here: https://github.com/python/cpython/pulls/picnixz

mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@picnixz @mrahtz
pythongh-120449: fix test_pyclbr introspection for mangled names (p…
717c8fd 
…ythonGH-120450)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@picnixz @noahbkim
pythongh-120449: fix test_pyclbr introspection for mangled names (p…
2b63e08 
…ythonGH-120450)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@picnixz @estyxx
pythongh-120449: fix test_pyclbr introspection for mangled names (p…
dc1129a 
…ythonGH-120450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@picnixz @erlend-aasland @nineteendo