Skip to content

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 29, 2024


(cherry picked from commit dd3a87d)

Co-authored-by: Илья Любавский 100635212+lubaskinc0de@users.noreply.github.com
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
Co-authored-by: Tomas R. tomas.roun8@gmail.com
Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com


📚 Documentation preview 📚: https://cpython-previews--127390.org.readthedocs.build/

---------

(cherry picked from commit dd3a87d)

Co-authored-by: Илья Любавский <100635212+lubaskinc0de@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@Eclips4
Copy link
Member

Eclips4 commented Nov 29, 2024

Merging 3.13 to get changes from 9bdb0ae

@terryjreedy
Copy link
Member

terryjreedy commented Nov 29, 2024

EDIT Failed again. Test threading this time (twice, as viewed in raw log).

2024-11-29T12:28:06.1851010Z FAIL: test_start_new_thread_failed (test.test_threading.ThreadTests.test_start_new_thread_failed)
2024-11-29T12:28:06.1851340Z ----------------------------------------------------------------------
2024-11-29T12:28:06.1851550Z Traceback (most recent call last):
2024-11-29T12:28:06.1851930Z   File "/Users/admin/actions-runner/_work/cpython/cpython/Lib/test/test_threading.py", line 1205, in test_start_new_thread_failed
2024-11-29T12:28:06.1852310Z     self.assertEqual(out, b'ok')
2024-11-29T12:28:06.1852470Z     ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
2024-11-29T12:28:06.1852660Z AssertionError: b"skip\nshouldn't be printed" != b'ok'

How to I deterministically get the summary log to display so it can be searched. Typing 'error' into search box and hitting return does not do it I have gotten it before with random clicking and keypresses.

@terryjreedy terryjreedy merged commit 4cba0e6 into python:3.13 Nov 30, 2024
38 checks passed
@Eclips4
Copy link
Member

Eclips4 commented Nov 30, 2024

@terryjreedy, I just reran the CI and it seemed to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants