Skip to content

gh-126944: Show explicit errors when required arguments of pdb commands are missing #130240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 18, 2025
Merged

gh-126944: Show explicit errors when required arguments of pdb commands are missing #130240

merged 4 commits into from
Feb 18, 2025

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Feb 17, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 17, 2025
Closed
hauntsaninja
hauntsaninja approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, sorry I forgot about it :-)

@gaogaotiantian
Copy link
Member Author

No worries, I forgot about it too. Browsing issues today and found one that's not solved :)

@gaogaotiantian gaogaotiantian merged commit 076300d into python:main Feb 18, 2025
43 checks passed
@gaogaotiantian gaogaotiantian deleted the check-required-args branch February 18, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaogaotiantian @hauntsaninja