Skip to content

gh-118761: Fix star-import of ast (alternative) #132025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

gh-118761: Fix star-import of ast (alternative) #132025

merged 2 commits into from
Apr 2, 2025

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 2, 2025 •
edited by bedevere-app bot
Loading

@AA-Turner this is an alternative to #132024 that feels simpler to me, let me know what you think!

@JelleZijlstra JelleZijlstra requested a review from AA-Turner April 2, 2025 17:41
@bedevere-app bedevere-app bot mentioned this pull request Apr 2, 2025
Closed
JelleZijlstra
JelleZijlstra commented Apr 2, 2025
View reviewed changes
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 2, 2025
Merged
AA-Turner
AA-Turner approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, this also incorporates Victor's suggestion. I've left a suggestion, and I also think we could add the deferred sys import from my PR.

A

@AA-Turner AA-Turner mentioned this pull request Apr 2, 2025
Closed
@AA-Turner AA-Turner enabled auto-merge (squash) April 2, 2025 17:56
@AA-Turner AA-Turner merged commit 06822bf into python:main Apr 2, 2025
38 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@JelleZijlstra @AA-Turner @seehwan80
pythongh-118761: Fix star-import of ast (python#132025)
f7ede84 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@Eclips4 Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner

+1 more reviewer

@danielhollas danielhollas danielhollas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JelleZijlstra @AA-Turner @danielhollas