[3.14] Make Android streams respect the unbuffered (-u) option (GH-138806)
#139108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…38806) Android pipes stdout/stderr to the log, which means every write to the log becomes a separate log line. As a result, most practical uses of stdout/stderr should be buffered; but it doesn't hurt to preserve unbuffered handling in case it's useful. (cherry picked from commit 0ac377f) Co-authored-by: Malcolm Smith <smith@chaquo.com>
miss-islington
requested review from
freakboy3742 and
mhsmith
as code owners
freakboy3742
approved these changes
Sep 18, 2025
|
Assigning to @hugovk while to the 3.14 branch block is in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android pipes stdout/stderr to the log, which means every write to the log
becomes a separate log line. As a result, most practical uses of stdout/stderr
should be buffered; but it doesn't hurt to preserve unbuffered handling in case
it's useful.
(cherry picked from commit 0ac377f)
Co-authored-by: Malcolm Smith smith@chaquo.com