Skip to content

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Feb 3, 2021

This adds a number of syslog facilities to the syslogmodule.c.
These values are available on macOS.

This adds a number of syslog facilities to the syslogmodule.c.
These values are available on macOS.
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 6, 2021
Copy link
Contributor

@akulakov akulakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way I also was not able to find some of these levels in man 3 syslog on my MacOS, (for example LOG_NETINFO, LOG_RAS, etc - but it's old, 10.12, so were they added more recently? I couldn't find them online either.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 3, 2022
@ronaldoussoren ronaldoussoren changed the title bpo-43120: Add a number of LOG_* constants to syslog gh-87286: Add a number of LOG_* constants to syslog Dec 7, 2023
* Fix patchcheck errors
* Rename NEWS.d entry to the right name (issue# istead of PR#)
This fixes a CI warning and matches the pattern
used in the documentation for ``os``.
LOG_INFO
LOG_DEBUG

Priority levels (high to low):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not it be above the previous list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be, currently it renders like this:

image

Where this text is the "description details" of the last "description term":

image

@hugovk
Copy link
Member

hugovk commented Dec 8, 2023

This now fixes all but one of the Sphinx warnings in this file! 👍

If you feel like polishing it off, we can fix the last one too:

 This module wraps the system ``syslog`` family of routines.  A pure Python
 library that can speak to a syslog server is available in the
-:mod:`logging.handlers` module as :class:`SysLogHandler`.
+:mod:`logging.handlers` module as :class:`~logging.handlers.SysLogHandler`.

And then remove Doc/library/syslog.rst from Doc/tools/.nitignore, which will prevent more warnings being added to the file in the future (re: #101100).

ronaldoussoren and others added 3 commits December 8, 2023 13:33
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@ronaldoussoren ronaldoussoren merged commit 0d2fe6b into python:main Dec 12, 2023
@ronaldoussoren ronaldoussoren deleted the bpo-43120 branch December 12, 2023 09:25
Comment on lines +2 to +3
:const:`LOG_INSTALL`, :const:`LOG_RAS`, and :const:`LOG_LAUNCHD` tot the
:mod:`syslog` module, all of them constants on used on macOS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe 'tot' should be 'to' and 'constants on used on' should be 'constants used on'.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
* bpo-43120: Add a number of LOG_* constants to syslog

This adds a number of syslog facilities to the syslogmodule.c.
These values are available on macOS.

* Switch contant documentation to the data directive

This fixes a CI warning and matches the pattern
used in the documentation for ``os``.

* Update Doc/library/syslog.rst


Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
* bpo-43120: Add a number of LOG_* constants to syslog

This adds a number of syslog facilities to the syslogmodule.c.
These values are available on macOS.

* Switch contant documentation to the data directive

This fixes a CI warning and matches the pattern
used in the documentation for ``os``.

* Update Doc/library/syslog.rst


Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants