Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PEP 3141 to 2.6 #46030

Closed
jyasskin mannequin opened this issue Dec 23, 2007 · 6 comments
Closed

Backport PEP 3141 to 2.6 #46030

jyasskin mannequin opened this issue Dec 23, 2007 · 6 comments
Labels
docs Documentation in the Doc dir stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@jyasskin
Copy link
Mannequin

jyasskin mannequin commented Dec 23, 2007

BPO 1689
Nosy @gvanrossum, @facundobatista
Files
  • backport_numbers.patch
  • backport_numbers_with_docs.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2008-03-16.19:47:12.521>
    created_at = <Date 2007-12-23.02:00:34.121>
    labels = ['type-bug', 'library', 'docs']
    title = 'Backport PEP 3141 to 2.6'
    updated_at = <Date 2008-03-16.19:47:12.520>
    user = 'https://bugs.python.org/jyasskin'

    bugs.python.org fields:

    activity = <Date 2008-03-16.19:47:12.520>
    actor = 'jyasskin'
    assignee = 'none'
    closed = True
    closed_date = <Date 2008-03-16.19:47:12.521>
    closer = 'jyasskin'
    components = ['Documentation', 'Library (Lib)']
    creation = <Date 2007-12-23.02:00:34.121>
    creator = 'jyasskin'
    dependencies = []
    files = ['9026', '9037']
    hgrepos = []
    issue_num = 1689
    keywords = []
    message_count = 6.0
    messages = ['58967', '58984', '59063', '59119', '63588', '63590']
    nosy_count = 3.0
    nosy_names = ['gvanrossum', 'facundobatista', 'jyasskin']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue1689'
    versions = ['Python 2.6']

    @jyasskin
    Copy link
    Mannequin Author

    jyasskin mannequin commented Dec 23, 2007

    This includes r50877 (just the complex_pow part), r56649, r56652,
    r56715, r57296, r57302, r57359, r57361, r57372, r57738, r57739, r58017,
    r58039, r58040, and r59390.

    @jyasskin jyasskin mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Dec 23, 2007
    @facundobatista
    Copy link
    Member

    The patch applies cleanly, all test cases are ok.

    To be commited, documentation should be created for this, would you
    please take care of it?

    Also, some lines for NEWS will be welcomed.

    Thank you!!

    @jyasskin
    Copy link
    Mannequin Author

    jyasskin mannequin commented Dec 31, 2007

    I've added some rudimentary documentation and a line for NEWS. Before
    the docs for this patch can really be finished, we'll need to figure out
    how we want to document ABCs. I'll think about that and probably send
    some more patches, but I don't think that should block the implementation.

    @jyasskin jyasskin mannequin added the docs Documentation in the Doc dir label Dec 31, 2007
    @jyasskin
    Copy link
    Mannequin Author

    jyasskin mannequin commented Jan 3, 2008

    I've committed this as r59671, except that round() returns a float again
    to make sure we keep compatibility. Let me know if you find anything
    that needs fixing.

    @gvanrossum
    Copy link
    Member

    Why can't this be closed?

    @jyasskin
    Copy link
    Mannequin Author

    jyasskin mannequin commented Mar 16, 2008

    It can. :)

    @jyasskin jyasskin mannequin closed this as completed Mar 16, 2008
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants