Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45138: Fix regression in GH-28240 #31783

Closed
wants to merge 5 commits into from
Closed

bpo-45138: Fix regression in GH-28240 #31783

wants to merge 5 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Mar 9, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

cc. @JelleZijlstra @pablogsal

@erlend-aasland erlend-aasland reopened this Mar 9, 2022
JelleZijlstra
JelleZijlstra approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I can merge it once we're both happy with it (cc @gvanrossum).

We should also test with buildbots though.

@erlend-aasland
Copy link
Contributor Author

We should also test with buildbots though.

I tried adding the buildbot label via the GH app, but for some reason it does not work. Feel free to send it to the bots now.

@JelleZijlstra JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 0ab2575 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2022
@erlend-aasland
Copy link
Contributor Author

s390x SLES PR failed. This PR needs more work.

@gvanrossum
Copy link
Member

IIUC the buildbots are still red. Maybe it's time to roll back the original commit? Then you can fix it without so much stress.

@erlend-aasland
Copy link
Contributor Author

IIUC the buildbots are still red. Maybe it's time to roll back the original commit? Then you can fix it without so much stress.

Yep, there are some red ones left; I think we should revert now, especially given Łukasz' recent plea about keeping the bots green. I'll close this and submit a new PR in a couple of days.

@erlend-aasland erlend-aasland deleted the fix-trace branch March 9, 2022 17:10
@JelleZijlstra
Copy link
Member

Thanks, yes I was also going to suggest reverting.

@erlend-aasland erlend-aasland mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag will be requested when the pull request is marked ready for review berkerpeksag is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @bedevere-bot @gvanrossum @JelleZijlstra @the-knights-who-say-ni