Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99275: Fix SystemError in ctypes during __initsubclass__ #99283

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 9, 2022

During __initsubclass__ not all parts required by PyType_stgdict are ready.
This PR just sets a better error message, without changing the semantics of the type creation.

@gpshead gpshead added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 13, 2022
@gpshead gpshead merged commit 343eb0f into python:main Nov 13, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99447 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2022
…_` (pythonGH-99283)

(cherry picked from commit 343eb0f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 13, 2022
@bedevere-bot
Copy link

GH-99448 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2022
…_` (pythonGH-99283)

(cherry picked from commit 343eb0f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 13, 2022
miss-islington added a commit that referenced this pull request Nov 13, 2022
…-99283)

(cherry picked from commit 343eb0f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Nov 13, 2022
…-99283)

(cherry picked from commit 343eb0f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants