Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Fix error in tutorial example: type(exc) is the type rather than the instance #102751

Merged
merged 1 commit into from
Mar 22, 2023
Merged

[doc] Fix error in tutorial example: type(exc) is the type rather than the instance #102751

merged 1 commit into from
Mar 22, 2023

Conversation

jenshb
Copy link
Contributor

@jenshb jenshb commented Mar 16, 2023

No description provided.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Mar 16, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 16, 2023
Eclips4
Eclips4 approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
However, printing type of exception which we catching, looks kinda weird. This always will be <class Exception>, but it's tutorial example, so that's ok.

@iritkatriel iritkatriel added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes skip issue and removed skip issue labels Mar 22, 2023
@iritkatriel iritkatriel changed the title type() doesn't return an instance but a type [doc] Fix error in tutorial example: type(exc) is the type rather than the instance Mar 22, 2023
@iritkatriel iritkatriel merged commit 8709697 into python:main Mar 22, 2023
@miss-islington
Copy link
Contributor

Thanks @jenshb for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @jenshb and @iritkatriel, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8709697292c67254ba836d7e88d1eba08c4a351a 3.10

@bedevere-bot
Copy link

GH-102928 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2023
@jenshb @miss-islington
[doc] Fix error in tutorial example: type(exc) is the type rather tha…
d913577 
…n the instance (pythonGH-102751)

(cherry picked from commit 8709697)

Co-authored-by: Jens-Hilmar Bradt <17177271+jenshb@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 22, 2023
miss-islington added a commit that referenced this pull request Mar 22, 2023
@miss-islington @jenshb
[doc] Fix error in tutorial example: type(exc) is the type rather tha…
f79cfb6 
…n the instance (GH-102751)

(cherry picked from commit 8709697)

Co-authored-by: Jens-Hilmar Bradt <17177271+jenshb@users.noreply.github.com>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@jenshb @Fidget-Spinner
[doc] Fix error in tutorial example: type(exc) is the type rather tha…
f8f08c2 
…n the instance (python#102751)
@jenshb jenshb deleted the patch-1 branch April 2, 2023 15:59
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@jenshb @warsaw
[doc] Fix error in tutorial example: type(exc) is the type rather tha…
699615e 
…n the instance (python#102751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@iritkatriel iritkatriel

Labels
docs Documentation in the Doc dir needs backport to 3.10 only security fixes skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jenshb @miss-islington @bedevere-bot @iritkatriel @Eclips4