Typing: improve docs on the type of class objects #106081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
skip issue
topic-typing
needs backport to 3.11
AlexWaygood
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
bedevere-bot
added
awaiting core review
docs
JelleZijlstra
approved these changes
Jun 26, 2023
hauntsaninja
approved these changes
Jun 26, 2023
|
Thanks @AlexWaygood for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-106096 is a backport of this pull request to the 3.12 branch. |
|
GH-106097 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2023
(cherry picked from commit 3eeb8c8) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2023
(cherry picked from commit 3eeb8c8) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
added a commit
that referenced
this pull request
Jun 26, 2023
AlexWaygood
added a commit
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs on
typing.Type[T]mostly contain information that applies equally well totype[T]. Move that information out of the entry fortyping.Type[T], and into its own section. Move the reduced entry fortyping.Type[T]into the "Deprecated aliases" section.Also improve the code examples slightly, and remove a reference to how PEP-484 might change in the future.
📚 Documentation preview 📚: https://cpython-previews--106081.org.readthedocs.build/