Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-107625: configparser: Raise ParsingError if a key contains empty value #107651

Merged
merged 23 commits into from
Mar 6, 2024
Merged

gh-107625: configparser: Raise ParsingError if a key contains empty value #107651

merged 23 commits into from
Mar 6, 2024
+55 −0

Conversation

Agent-Hellboy
Copy link
Contributor

@Agent-Hellboy Agent-Hellboy commented Aug 5, 2023 •
edited
Loading

  • raise ParsingError instead of AttributeError if a key contains an empty value in a non-recommended scenario where extra space and a blank line is present within the section

📚 Documentation preview 📚: https://cpython-previews--107651.org.readthedocs.build/

@Agent-Hellboy
pythongh-107625: Raise ParsingError if a key contains empty value
ec49bca 
- raise ParsingError instaed of AttributeError if a key
  contains empty value in a non recommended scenario where
  extra space and blankline is present within the section
@bedevere-bot bedevere-bot mentioned this pull request Aug 5, 2023
Closed
2 tasks
@AlexWaygood AlexWaygood changed the title gh-107625: Raise ParsingError if a key contains empty value gh-107625: configparser: Raise ParsingError if a key contains empty value Aug 5, 2023
ericvsmith
ericvsmith reviewed Aug 5, 2023
View reviewed changes
Doc/library/configparser.rst Outdated Show resolved Hide resolved
Doc/library/configparser.rst Outdated Show resolved Hide resolved
merwok
merwok reviewed Aug 5, 2023
View reviewed changes
Doc/library/configparser.rst Outdated Show resolved Hide resolved
merwok
merwok reviewed Aug 5, 2023
View reviewed changes
Doc/library/configparser.rst Outdated Show resolved Hide resolved
merwok
merwok reviewed Aug 5, 2023
View reviewed changes
Lib/configparser.py Outdated Show resolved Hide resolved
Agent-Hellboy and others added 2 commits August 6, 2023 00:21
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Agent-Hellboy
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ambv August 11, 2023 04:14
@ambv
Copy link
Contributor

ambv commented Aug 11, 2023

Closing and re-opening to retrigger CLA checks. Sorry for the noise.

@ambv ambv closed this Aug 11, 2023
@ambv ambv reopened this Aug 11, 2023
@Agent-Hellboy
Copy link
Contributor Author

Hi @ambv, I thought you closed the PR, but it's still open, I have resolved your comments, please look again.

@encukou
Copy link
Member

encukou commented Mar 4, 2024

I've merged main to fix a conflict, and reworded the docs & error to be more succinct. I hope you don't mind me pushing directly to the PR -- I wanted to test my suggestions locally so I already had them as commits.
Does this wording look OK to you?

jaraco
jaraco reviewed Mar 4, 2024
View reviewed changes
Lib/configparser.py Outdated Show resolved Hide resolved
jaraco
jaraco approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Agent-Hellboy @jaraco
Update Lib/configparser.py
9dc65ed 
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@Agent-Hellboy
Copy link
Contributor Author

Does this wording look OK to you?

yeah, it's better than the earlier error. Thanks

@encukou encukou dismissed ambv’s stale review March 6, 2024 13:40

The issues were resolved

@encukou encukou enabled auto-merge (squash) March 6, 2024 13:41
@encukou encukou merged commit e800265 into python:main Mar 6, 2024
31 checks passed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@Agent-Hellboy @merwok
@encukou @jaraco @adorilson
pythongh-107625: configparser: Raise error if a missing value is cont…
e53e133 
…inued (pythonGH-107651)


Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Agent-Hellboy @merwok
@encukou @jaraco @diegorusso
pythongh-107625: configparser: Raise error if a missing value is cont…
ca0a8aa 
…inued (pythonGH-107651)


Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@hugovk hugovk hugovk left review comments

@merwok merwok merwok left review comments

@ericvsmith ericvsmith ericvsmith left review comments

@jaraco jaraco jaraco approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Agent-Hellboy @bedevere-bot @ambv @encukou @jaraco @ericvsmith @merwok @hugovk @AA-Turner