Docs: skip python-docs-theme 2023.7 to fix mobile menu #107666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
added
skip issue
skip news
needs backport to 3.11
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-107690 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2023
(cherry picked from commit 9641c4d) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
GH-107691 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2023
(cherry picked from commit 9641c4d) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
added a commit
that referenced
this pull request
Aug 6, 2023
Yhg1s
pushed a commit
that referenced
this pull request
Aug 6, 2023
hugovk
added a commit
to python/python-docs-theme
that referenced
this pull request
Aug 14, 2023
hugovk
added a commit
to hugovk/python-docs-theme
that referenced
this pull request
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip python-docs-theme 2023.7 because python/python-docs-theme#141 means the menu doesn't work properly for mobile. Upstream report: python/python-docs-theme#144.
To test:
Expected result: menu opens (https://cpython-previews--107666.org.readthedocs.build/en/107666/)
Actual result: menu doesn't open (https://docs.python.org/3.13/)
📚 Documentation preview 📚: https://cpython-previews--107666.org.readthedocs.build/